[RTE-606] Merge fortanixvme branch #833
Conversation
…-fortanixvme-branch
| sha256: &'static str, | ||
| } | ||
|
|
||
| const BLOBS: [Blob; 5] = [ |
There was a problem hiding this comment.
Nitpick: It'd make sense if you moved this BLOBS definition (or only its components) to aws-nitro-blobs and rename this crate into verified-downloader or something better. That way it can be easily re-used.
There was a problem hiding this comment.
I removed aws-nitro-blobs-downloader completely.
| .build() | ||
| .expect("Unable to initialize downloader"); | ||
|
|
||
| let mut lines = Vec::with_capacity(NITRO_BLOBS.len()); |
There was a problem hiding this comment.
Nit: the capacity is certainly incorrect it NITRO_BLOBS.len() will just return 5, but you need way more space than that. I'd just use the default capacity. (You could also just write things to file directly, without using this Vec)
There was a problem hiding this comment.
I simplified this file. it doesn't collect all lines in advance now. It just writes a line as a blob becomes ready.
…-fortanixvme-branch
This PR intends to merge
fortanixvme-2023-05-07-alphaintomaster.